Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix query height issue with IBC proofs #411

Closed
wants to merge 1 commit into from
Closed

Fix query height issue with IBC proofs #411

wants to merge 1 commit into from

Conversation

jackzampolin
Copy link
Member

Description

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

colin-axner
colin-axner approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a changelog entry? It can go under bug fixes

@jackzampolin
Copy link
Member Author

Do we need this if we get cosmos/cosmos-sdk#10144 into the v0.44.x line?

@colin-axner
Copy link
Contributor

Do we need this if we get cosmos/cosmos-sdk#10144 into the v0.44.x line?

Nope, that change fixes the root issue of the request.Height value being ignored

@jackzampolin jackzampolin deleted the patch-1 branch September 15, 2021 15:34
faddat pushed a commit to notional-labs/ibc-go that referenced this pull request Mar 1, 2022
@ilgooz
feat(cmd): make root command publicly accessible (cosmos#411)
f4b5685 
so, it can be reused as a sub command by other cobra compatible CLIs. e.g. (start relayer rly -h)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-axner colin-axner colin-axner approved these changes

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@fedekunze fedekunze Awaiting requested review from fedekunze

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackzampolin @colin-axner